Github help
-
Anyone want to give me a quick rundown of how to work Github? In a nutshell, I have modified the script from BitcoinPaperWallet.com and asked a buddy who does Photoshop on the side to make a Feathercoin design that works on that site. It works, Ive printed a few wallets off with no issues and would like to share it with the community. I thought about zipping it and uploading it here but with so few posts and no reputation here I didnt want to have people thinking I was trying to spread a virus or anything.
Anyway, I signed up for an account on Github but I dont understand the terminology or what the process is to submit my modified code/files to the site. I see others have done this but I dont want to do anything wrong.
https://github.com/cantonbecker/bitcoinpaperwallet
Thanks for any assistance you can provide. I’ll start a new thread once I get this online and hope to see some feedback.
-
OK are you wanting to merge your changes into their code or create your own copy?
If its the second one you should first create an empty git repo on github then clone that to your local file system.
(I’ve only ever done this with linux but I guess it should be rhe same on windows)Git clone https://githib.com/your-repo
Then copy your classes / code in to the newly creates git folder.
cd your-repo folder
Git add . (adds all files . is important)
Git commit -m=“your commit comment”
Git push -u origin master
Hope that helps
-
haha, Im sorry but thats no help to me at all! :) I know literally zero about Github, how it works or what its for really.
If you look at that link in the OP and click Pull Request to the right there are modified files that other people have somehow uploaded. I want to do that. I dont think its merging into his code but I guess its not under my own account either… Basically, I added a Feathercoin option to his site and Id like to share it but I dont know the best way to do this. Id like to still give him full credit for creating 99.9% of the code, All I did was add about 10 lines to it.
EDIT: PS, thanks for the reply. Sorry I just dont know what Im doing.
-
Hey that’s OK I’m a github newbie too I’ve only ever cloned other peoples code or added my own.
I think the steps may be similar for a pull request. Do you have git installed on your PC? Are you on Linux or windows? I’ll have a read see what’s needed. :) -
Looks like the first thing you need to do is create a branch of his code. You can do this from there github repository on the website. As seen in this link.
A branch is just a copy of all there code that you can change.
-
Then follow the instructions in my original post but on your branch.
Cloning will copy all the code to your PC
Then you will need to change the file with 10 lines as you said before
Then add your file with git add
Then push your changes back up to github -
Last thing is to create a pull request. That is just a request that they review and potentially add the differences between your version of the code and Thiers. Here is a walk through link
-
Hey that’s OK I’m a github newbie too I’ve only ever cloned other peoples code or added my own.
I think the steps may be similar for a pull request. Do you have git installed on your PC? Are you on Linux or windows? I’ll have a read see what’s needed. :)haha good, I feel really dumb that I cant work a simple website. lol
I have windows, didnt know there was anything to install…
I’ll give this a try and see what I can come up with. The guy told me he would review my code to make sure its correct. I hope he double checks to make sure I didnt add anything “extra”.
Thanks for the help, as always!
-
Ah if its windows it should be very similar but you will have to install git. Git is just a source repository a bit like svn but the difference is you create a local repository and make your changes there then push them to another person or github or bitbucket.
I think there is a windows installer of git.
In fact I’ve just found a github GUI for windows that might help?
Let me know how you get on.
-
Ok, so I admit defeat.
I have no idea what Im doing… I installed the program and was able to upload all the files to my own account on Github but i dont think thats what I wanted to do.
I think I’ll just start a thread explaining how to change the code and upload the images allowing others to make the changes themselves.
thanks for the help tho, Kris!
-
no problem I can always try and do it for you once you have posted the changes but I’ll try to make the point that I should not be given the credit for the work :)
-
Forum post: https://forum.feathercoin.com/index.php?/topic/8321-ftc-paper-wallet/#entry72126
My attempt at Github: https://github.com/AmDDJunkie/BTCPaperWallet